Skip to content

Fix: prevent rope_embedding AssertionError by checking kv_seq_len before reuse #3578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 14, 2025
Merged

Fix: prevent rope_embedding AssertionError by checking kv_seq_len before reuse #3578

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13235da
fix: add kv_seq_len boundary check before reusing RoPE embeddings
Nov 11, 2025
1fea4fa
Merge branch 'unslothai:main' into main
jarrycyx Nov 11, 2025
4019686
Merge branch 'unslothai:main' into main
jarrycyx Nov 12, 2025
e7e127c
fix falcon h1
Nov 12, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'unslothai:main' into main
  • Loading branch information
@jarrycyx
jarrycyx authored Nov 12, 2025
commit 401968661d623708661d3c15c06714c11918d1a5

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.