-
-
Notifications
You must be signed in to change notification settings - Fork 4k
pre-commit CI config #3565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre-commit CI config #3565
Conversation
Summary of ChangesHello @djsaunde, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the necessary configuration to integrate Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
59d07a2 to
6a08d67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a configuration file for pre-commit.ci to automate running pre-commit hooks on pull requests. The configuration is well-structured. I've provided one suggestion to improve maintainability by removing configuration options that are set to their default values, which makes the file more concise.
On a side note, the PR title 'auto-enable sample packing' seems unrelated to the changes. You might want to update it to something like 'Configure pre-commit.ci' to better reflect the content of this PR and improve the clarity of the repository's history.
| autofix_prs_limit: 5 | ||
| autoupdate_schedule: monthly | ||
| autoupdate_commit_msg: "chore: pre-commit autoupdate" | ||
| skip: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For improved readability and maintainability, it's good practice to omit configuration options that are set to their default values. Both autofix_prs_limit (defaults to 5) and skip (defaults to []) are set to their defaults here and can be removed.
autoupdate_schedule: monthly
autoupdate_commit_msg: "chore: pre-commit autoupdate"
Config for https://pre-commit.ci/. This will run our pre-commit hooks and create a commit with any changes (ruff format, etc.).
I've requested to enable the corresponding pre-commit CI GitHub app. We should merge this PR, then enable the app so it respects this config.