Skip to content

Conversation

@mmathew23
Copy link
Collaborator

add trust_remote_code kwarg so that we don't get prompted to accept remote code.

Running with this branch fixes the issue:
https://colab.research.google.com/drive/1o1pVBsG50Jo61k7MtNSKBasSwc-MbhuG?usp=sharing

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @mmathew23, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the model loading mechanism for vision models by integrating the trust_remote_code parameter. This modification is crucial for improving the user experience by eliminating repetitive security prompts during model initialization, particularly benefiting workflows involving models like DeepseekOCR by allowing for more seamless and automated execution.

Highlights

  • Feature Enhancement: Introduced the trust_remote_code keyword argument to the from_pretrained function within the vision model loading logic.
  • User Experience Improvement: This change aims to prevent prompts for accepting remote code, streamlining the model loading process for users.
  • Issue Resolution: Specifically addresses an issue encountered with DeepseekOCR, as demonstrated by a provided Colab notebook.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the trust_remote_code keyword argument to a call to AutoConfig.from_pretrained within the FastBaseModel.from_pretrained method. This is a necessary bug fix to ensure that the trust_remote_code flag is correctly propagated, which prevents interactive prompts when loading models that require remote code execution. The change is correct and consistent with how this argument is handled elsewhere in the function. I approve this change.

@danielhanchen danielhanchen merged commit 6efe10a into unslothai:main Nov 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants