Skip to content

Fix docstring removing regex to support empty parentheses #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2025
Merged

Fix docstring removing regex to support empty parentheses #360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions unsloth_zoo/compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,8 +806,8 @@ def create_standalone_class(
source = source + full_class

# Remove @auto_docstring
source = re.sub(r"@auto_docstring[\s]{0,}(\([^\)]{1,}\))?", "", source)
source = re.sub(r"@check_model_inputs[\s]{0,}(\([^\)]{1,}\))?", "", source)
source = re.sub(r"@auto_docstring[\s]{0,}(\([^\)]{0,}\))?", "", source)
source = re.sub(r"@check_model_inputs[\s]{0,}(\([^\)]{0,}\))?", "", source)
Comment on lines +809 to +810
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the change is functionally correct, the regular expressions can be simplified for better readability by using common regex quantifiers. [\s]{0,} can be replaced with \s*, and [^\)]{0,} can be replaced with [^\)]*.

Suggested change
source = re.sub(r"@auto_docstring[\s]{0,}(\([^\)]{0,}\))?", "", source)
source = re.sub(r"@check_model_inputs[\s]{0,}(\([^\)]{0,}\))?", "", source)
source = re.sub(r"@auto_docstring\s*(\([^\)]*\))?", "", source)
source = re.sub(r"@check_model_inputs\s*(\([^\)]*\))?", "", source)
# source = source.replace("@auto_docstring", "")

# Fix Gemma 3 ignore_index being not set!
Expand Down