Conversation
There was a problem hiding this comment.
Pull request overview
Updates the documentation site’s SDK badge behavior to display the Uno SDK version correctly and improves the “update instructions” modal styling/content.
Changes:
- Move the SDK badge element into the
.subnavcontainer at runtime so it’s positioned correctly. - Switch NuGet version lookup from
uno.templatestouno.sdkand update the modal copy/links accordingly. - Update modal styling (wider modal + new note variants) and refresh compiled/minified assets (CSS/JS + source maps).
Reviewed changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| doc/templates/uno/main.js | Enable SDK badge DOM move; fetch uno.sdk versions; update modal content/links. |
| doc/templates/uno/main.scss | Style updates for the SDK modal (max width + instruction/important note variants). |
| doc/templates/uno/styles/main.js | Updated minified/bundled JS reflecting main.js changes. |
| doc/templates/uno/styles/main.js.map | Updated JS sourcemap reflecting rebuilt JS bundle. |
| doc/templates/uno/styles/main.css | Updated compiled CSS reflecting SCSS changes. |
| doc/templates/uno/styles/main.css.map | Updated CSS sourcemap reflecting rebuilt CSS bundle. |
| doc/templates/uno/styles/docfx.js | Rebuilt/minified docfx script output (function ordering changed). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 8 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22511/docs/index.html |
Co-authored-by: Jen-Uno <214558326+Jen-Uno@users.noreply.github.com>
fix(docs): use aka link for SDK upgrade guide in badge modal
|
|
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22511/docs/index.html |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 8 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Jen-Uno <214558326+Jen-Uno@users.noreply.github.com>
Co-authored-by: Jen-Uno <214558326+Jen-Uno@users.noreply.github.com>
[WIP] Fix SDK badge in documentation
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22511/docs/index.html |
|
@Mergifyio backport release/stable/6.5 |
❌ No backport have been createdDetails
Git reported the following error: |
fixed SDK badge (backport #22511)
GitHub Issue: closes ##22409
PR Type:
What is the current behavior? 🤔
What is the new behavior? 🚀
PR Checklist ✅
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information ℹ️