Prerequisites
Description
I've been working on https://raw.githubusercontent.com/DandelionSprout/adfilt/master/LegitimateURLShortener.txt for some weeks now, which I did while presuming that only AdGuard had a feature to remove $/& parameters from URLs. But during some syntax checking of regional lists, I discovered that $queryprune seems to have been added to uBO.
However, those two $ qualifiers seem to me to do the exact same thing, with only 2 current exceptions:
- AdGuard removes the parameters at the network level instead of in the URL bar
$removeparam does not seem to need | in its values.
I therefore propose that they should be made into aliases of each other. This would save me from having to maintain and sync two different versions of that list, one for uBO and one for AdGuard.
A specific URL where the issue occurs
https://raw.githubusercontent.com/DandelionSprout/adfilt/master/LegitimateURLShortener.txt
Steps to Reproduce
- Turn on uBO's logger
- Set the tab to "All"
- Attempt to add or sync https://raw.githubusercontent.com/DandelionSprout/adfilt/master/LegitimateURLShortener.txt
- See that the logger considers all its entries to be an
Invalid network filter in https://raw.githubusercontent.com/DandelionSprout/adfilt/master/LegitimateURLShortener.txt:.
Expected behavior:
$removeparam is treated as being $queryprune
Actual behavior:
$removeparam does not work in uBO.
Your environment
- uBlock Origin version: 1.31.1b2
- Browser Name and version: Chrome 87.0.4280.66 x64
- Operating System and version: Windows 10 October 2020 Update
Prerequisites
Description
I've been working on https://raw.githubusercontent.com/DandelionSprout/adfilt/master/LegitimateURLShortener.txt for some weeks now, which I did while presuming that only AdGuard had a feature to remove $/& parameters from URLs. But during some syntax checking of regional lists, I discovered that
$querypruneseems to have been added to uBO.However, those two
$qualifiers seem to me to do the exact same thing, with only 2 current exceptions:$removeparamdoes not seem to need|in its values.I therefore propose that they should be made into aliases of each other. This would save me from having to maintain and sync two different versions of that list, one for uBO and one for AdGuard.
A specific URL where the issue occurs
https://raw.githubusercontent.com/DandelionSprout/adfilt/master/LegitimateURLShortener.txt
Steps to Reproduce
Invalid network filter in https://raw.githubusercontent.com/DandelionSprout/adfilt/master/LegitimateURLShortener.txt:.Expected behavior:
$removeparamis treated as being$querypruneActual behavior:
$removeparamdoes not work in uBO.Your environment