Skip to content

Conversation

@elrion018
Copy link
Contributor

@elrion018 elrion018 commented Sep 6, 2025

🎯 Changes

스크린샷 2025-09-06 오후 5 09 57

Remove unused @trpc/server/observable import from the minimal example
server to keep the example code clean and focused.

✅ Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

Summary by CodeRabbit

  • Chores
    • Removed an unused import in the minimal example server.
    • No changes to public APIs or exported types; existing behavior remains unchanged.
    • No impact on runtime behavior or error handling.
    • Slight reduction in build warnings for the example.
    • No user-facing changes.
Remove unused '@trpc/server/observable' import from the minimal example server.
@elrion018 elrion018 requested a review from a team as a code owner September 6, 2025 08:09
@vercel
Copy link

vercel bot commented Sep 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
www Ready Ready Preview Comment Sep 6, 2025 8:11am
@vercel
Copy link

vercel bot commented Sep 6, 2025

@elrion018 is attempting to deploy a commit to the trpc Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 6, 2025

Walkthrough

Removed an unused import of observable from @trpc/server/observable in examples/minimal/src/server/index.ts. No other code or exports were modified.

Changes

Cohort / File(s) Summary
Cleanup: remove unused import
examples/minimal/src/server/index.ts
Deleted unused observable import; no changes to exports or runtime logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I nibbled a stray import, hop-hop—gone!
The code now lighter, morning’s tidy dawn.
No types disturbed, no routes askew,
Just sweeping crumbs the linter knew.
With whiskers twitching, I approve—
Less fluff, more groove.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5f897bd and ca39232.

📒 Files selected for processing (1)
  • examples/minimal/src/server/index.ts (0 hunks)
💤 Files with no reviewable changes (1)
  • examples/minimal/src/server/index.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: test
  • GitHub Check: Lint and auto-fix
  • GitHub Check: typecheck
  • GitHub Check: build
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 6, 2025

Open in StackBlitz

@trpc/client

npm i https://pkg.pr.new/trpc/trpc/@trpc/client@6932

@trpc/next

npm i https://pkg.pr.new/trpc/trpc/@trpc/next@6932

@trpc/react-query

npm i https://pkg.pr.new/trpc/trpc/@trpc/react-query@6932

@trpc/server

npm i https://pkg.pr.new/trpc/trpc/@trpc/server@6932

@trpc/tanstack-react-query

npm i https://pkg.pr.new/trpc/trpc/@trpc/tanstack-react-query@6932

@trpc/upgrade

npm i https://pkg.pr.new/trpc/trpc/@trpc/upgrade@6932

commit: ca39232

@KATT KATT enabled auto-merge (squash) September 6, 2025 11:26
@KATT KATT merged commit 71b78ae into trpc:main Sep 9, 2025
74 of 78 checks passed
@github-actions
Copy link
Contributor

This pull request has been locked because we are very unlikely to see comments on closed issues. If you think, this PR is still necessary, create a new one with the same branch. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

2 participants