-
Notifications
You must be signed in to change notification settings - Fork 2k
feature/integrate gcs kms bucket for storing images #969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feature/integrate gcs kms bucket for storing images #969
Conversation
Overview: - KMS-protected buckets gives full control over encryption keys (vs Google-managed keys), granular permissions: You can restrict access to specific keys per team or service, and rotation & auditability: You can rotate keys periodically and audit access using Cloud Logging.
|
implemented the same approach on an enterprise solution
|
|
Cool, thanks.
I'm not sure what you mean by this. Do you want to set |
|
@or-else i am trying to test the upper limit of the integration (e.g rps on which the integration to kms buckets break). One use case i see here is that we can offload all images and attachment to the cloud instead of saving to db. I see it as a path for optimization here. Todo this, we need to send everything to gcs by lowering the maxInBandAttachmensize or disabling (i will do this locally) |
|
OK, makes sense. |
|
Should I review this PR now too? |
|
Any update on this? |
|
@or-else will update tomorrow. thanks! |
|
Any update on this? |
|
@ercsnmrs Please let me know if you wish to continue with this PR. |
Overview: