Add HashiCorp Vault module #1079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cristianrgreco
added
enhancement
Contributor
Author
|
Thanks for putting the time into reviewing this. I'll address the remarks, and ask for another review. |
Co-authored-by: Cristian Greco <cristianrgreco@gmail.com>
Co-authored-by: Cristian Greco <cristianrgreco@gmail.com>
Co-authored-by: Cristian Greco <cristianrgreco@gmail.com>
Co-authored-by: Cristian Greco <cristianrgreco@gmail.com>
Co-authored-by: Cristian Greco <cristianrgreco@gmail.com>
cristianrgreco
approved these changes
Jul 18, 2025
Collaborator
|
Thanks, @inf1nite-lo0p! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
VaultContainerbased on the officialhashicorp/vaultimage.Supports health check on
/v1/sys/health, root token configuration, and CLI-based initialization via vault commands.Includes integration tests using node-vault to validate read/write and transit key setup.
Took inspiration for impelmenting this from the existing Java implementation:
https://github.com/testcontainers/testcontainers-java/blob/main/modules/vault/src/main/java/org/testcontainers/vault/VaultContainer.java