Skip to content

feat: add support for setting build environment variables #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

grumpydude
Copy link

This adds the capability to pass build time environment variables such as GOOGLE_FUNCTION_SOURCE.

@comment-bot-dev
Copy link

Thanks for the PR! 🚀
Unfortunately it looks like some of our CI checks failed. See the Contributing Guide for details.

  • ⚠️check_terraform
    Failed Terraform check. More details below.
Running terraform fmt
Running terraform validate
terraform_validate . 
╷
│

Error: 
Unsupported argument
│

│

 on main.tf line 89, in module "main":
│

 89:   
build_environment_variables
       = var.build_environment_variables
│

│

An argument named "build_environment_variables" is not expected here.
╵
terraform_validate ./examples/logs-slack-alerts 
╷
│

Error: 
Unsupported argument
│

│

 on ../../main.tf line 89, in module "main":
│

 89:   
build_environment_variables
       = var.build_environment_variables
│

│

An argument named "build_environment_variables" is not expected here.
╵
terraform_validate ./examples/pubsub_scheduled 
╷
│

Error: 
Unsupported argument
│

│

 on ../../main.tf line 89, in module "main":
│

 89:   
build_environment_variables
       = var.build_environment_variables
│

│

An argument named "build_environment_variables" is not expected here.
╵
terraform_validate ./examples/pubsub_scheduled_multiple 
╷
│

Error: 
Unsupported argument
│

│

 on ../../main.tf line 89, in module "main":
│

 89:   
build_environment_variables
       = var.build_environment_variables
│

│

An argument named "build_environment_variables" is not expected here.
╵
terraform_validate ./modules/project_cleanup 
╷
│

Error: 
Unsupported argument
│

│

 on ../../main.tf line 89, in module "main":
│

 89:   
build_environment_variables
       = var.build_environment_variables
│

│

An argument named "build_environment_variables" is not expected here.
╵
terraform_validate ./test/fixtures/pubsub_scheduled 
╷
│

Error: 
Unsupported argument
│

│

 on ../../../main.tf line 89, in module "main":
│

 89:   
build_environment_variables
       = var.build_environment_variables
│

│

An argument named "build_environment_variables" is not expected here.
╵
terraform_validate ./test/setup 
Success!
The configuration is valid.
@grumpydude grumpydude closed this Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants