Skip to content

Multiple event functions with the same scheduler prototype. #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Multiple event functions with the same scheduler prototype. #27

wants to merge 2 commits into from

Conversation

omazin
Copy link
Contributor

@omazin omazin commented Dec 6, 2019 •
edited
Loading

2nd approach to solve #15
This was referenced Dec 11, 2019
Closed
Merged
ocervell
ocervell suggested changes Dec 18, 2019
View reviewed changes
Copy link

@ocervell ocervell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not need to use two separate modules for the same thing, just because we want to share a resource. This should be done via input variable + dependency between modules.

IMO we don't need a new module at all, we should be able to edit the main.tf file in the main module to make this fix.

I prefer your approach at fixing this in #26 and with a few minor we are close to completion there :)
@omazin
Copy link
Contributor Author

omazin commented Dec 18, 2019

Agreed
@omazin omazin closed this Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@omazin @ocervell