Skip to content

Update testing to CloudBuild #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 25, 2019
Merged

Update testing to CloudBuild #18

merged 7 commits into from
Sep 25, 2019

Conversation

averbuks
Copy link
Member

@averbuks averbuks commented Sep 24, 2019 •
edited by morgante
Loading

Fix #14 (doc_generator tags and update docs)
Fix #17 (Update testing to CloudBuild and general linting)
@morgante
Copy link
Contributor

@averbuks Looks like tests are failing?
@aaron-lane aaron-lane added the enhancement New feature or request label Sep 25, 2019
@morgante morgante merged commit a9db806 into terraform-google-modules:master Sep 25, 2019
@averbuks averbuks deleted the averbuks-update-to-cloudbuild branch September 25, 2019 15:23
@averbuks
Copy link
Member Author

@morgante the first few tests were failing because AppEngine API was disabled for cd-cd project where the CB is run, thanks @aaron-lane for helping on this.
But what I also noticed that test was failing because Cloud Storage JSON API is not enabled (and we have it enabled in the setup code). I assume it's because of some delay for API Enablement process.
paulpalamarchuk pushed a commit to paulpalamarchuk/terraform-google-scheduled-function that referenced this pull request Nov 1, 2019
@morgante @paulpalamarchuk
Merge pull request terraform-google-modules#18 from averbuks/averbuks…
628d069 
…-update-to-cloudbuild

Update testing to CloudBuild
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
3 participants
@averbuks @morgante @aaron-lane