feat(TPG >=4.23)!: Add function_docker_registry variables and use them in terraform-google-event-function module

[tardigrde]

This is a follow-up PR to terraform-google-modules/terraform-google-event-function#164. It depends on that PR, so it will be in draft until the other one is merged.

The scope of this PR is the same as the dependency PR. Variables added:

• function_docker_registry
• function_docker_repository
• function_kms_key_name

This enables storing Cloud Build container in Artifact Registry.

See https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/cloudfunctions_function#docker_registry

[tardigrde]

Hi again @apeabody ! I'd then extend this module as well with the 3 variables used now in https://github.com/terraform-google-modules/terraform-google-event-function. Could you please review it + gcbrun?

[apeabody]

/gcbrun

[alexrohv]

@tardigrde Hey, can you update the branch so that @apeabody can have a look? If you're busy, I can work on it.

[tardigrde]

Updated!

[tardigrde]

Updated the branch! @apeabody can you please move this forward somehow?

[apeabody]

/gcbrun

[tardigrde]

No update since..

[apeabody]

/gcbrun

[apeabody]

Hi @tardigrde - From the lint it needs a make docker_generate_docs

Checking for documentation generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=autogen' '--exclude=*.tfvars' '--exclude=*metadata.yaml' /workspace/README.md /tmp/tmp.h0veMwqh1U/generate_docs/workspace/README.md
73c73
< | vpc\_connector | The VPC Network Connector that this cloud function can connect to. It should be set up as fully-qualified URI. The format of this field is projects//locations//connectors/\*. | `string` | `null` | no |
---
> | vpc\_connector | The VPC Network Connector that this cloud function can connect to. It should be set up as fully-qualified URI. The format of this field is projects//locations//connectors/*. | `string` | `null` | no |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=autogen' '--exclude=*.tfvars' '--exclude=*metadata.yaml' /workspace/examples/logs-slack-alerts/README.md /tmp/tmp.h0veMwqh1U/generate_docs/workspace/examples/logs-slack-alerts/README.md
30c30
< No output.
---
> No outputs.
Error: Documentation generation has not been run, please run the
'make docker_generate_docs' command and commit the above changes.

[github-actions]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

[alexrohv]

@tardigrde @apeabody Any issues if I take over and open a new PR? I can build off the current commits. I've been waiting quite a while for this to get merged in.

[tardigrde]

@alexrohv please take over. :)

[tardigrde]

Closing since @alexrohv will take over.

Thanks so far!