Initial Commit #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marko7460
reviewed
Feb 26, 2019
added 2 commits
March 1, 2019 10:59
aaron-lane
suggested changes
Mar 1, 2019
aaron-lane
suggested changes
Mar 12, 2019
Co-Authored-By: ogreface <rishi@rishim.com>
Co-Authored-By: ogreface <rishi@rishim.com>
Co-Authored-By: ogreface <rishi@rishim.com>
Co-Authored-By: ogreface <rishi@rishim.com>
Co-Authored-By: ogreface <rishi@rishim.com>
Co-Authored-By: ogreface <rishi@rishim.com>
Co-Authored-By: ogreface <rishi@rishim.com>
aaron-lane
suggested changes
Mar 12, 2019
There was a problem hiding this comment.
I attempted to run the tests and came across some variable caveats. Additionally, given that the google_cloud_scheduler_job resource has a hard dependency on the existence of an App Engine application, we should document that and instantiate one in the example.
Error: Error applying plan:
1 error(s) occurred:
* module.pubsub_scheduled_example.module.pubsub_scheduled_example.google_cloud_scheduler_job.job: 1 error(s) occurred:
* google_cloud_scheduler_job.job: Error creating Job: googleapi: Error 404: The project aaronlane-s7d-f6n-test-c257 does not contain an App Engine application. Please visit https://console.developers.google.com/appengine?project=aaronlane-s7d-f6n-test-c257 to to add an App Engine application.
Co-Authored-By: ogreface <rishi@rishim.com>
aaron-lane
suggested changes
Mar 14, 2019
added 2 commits
March 14, 2019 13:59
aaron-lane
approved these changes
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.