Skip to content

Conversation

@tomchon
Copy link
Contributor

@tomchon tomchon commented Oct 22, 2025

No description provided.

@tomchon tomchon requested review from a team and feici02 as code owners October 22, 2025 06:52
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tomchon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a mechanism to control whether tests are built as part of the main project compilation. By making the BUILD_TEST flag configurable through environment variables in both Windows and Unix-like build scripts, it provides greater flexibility, particularly for CI environments where skipping test compilation might be desired to reduce build times.

Highlights

  • Configurable Test Builds: The BUILD_TEST flag is now configurable in both build.bat and build.sh scripts, allowing the build process to optionally skip compiling tests.
  • CI Optimization: This change enables disabling test compilation during CI builds, which can help optimize build times for specific continuous integration pipelines.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/tdengine-build.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables test building during the TDengine build CI process to optimize build times. The changes introduce a BUILD_TEST environment variable that defaults to true for backward compatibility but can be set to false in CI workflows.

Key changes:

  • Added BUILD_TEST environment variable support in build scripts with default value of true
  • Updated CI workflow to explicitly set BUILD_TEST=false during all build steps

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
build.sh Modified to use BUILD_TEST environment variable instead of hardcoded true value
build.bat Added BUILD_TEST environment variable with default value and updated cmake configuration
.github/workflows/tdengine-build.yml Set BUILD_TEST=false for all build steps in Linux, macOS, and Windows builds

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a mechanism to control test builds via the BUILD_TEST environment variable in both build.bat and build.sh. The changes correctly default the variable to true if it's not set, allowing it to be overridden (e.g., in a CI environment) to disable building tests. The implementation is idiomatic for both batch and shell scripts. I've made one minor suggestion to fix the alignment in build.sh for consistency. Otherwise, the changes look good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants