Skip to content

Refactor chat memory usage #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 22, 2023
Merged

Refactor chat memory usage #39

merged 3 commits into from
Nov 22, 2023

Conversation

@walison17
Copy link
Collaborator

@walison17 walison17 commented Nov 22, 2023 •
edited by avelino
Loading

  • Remove manually interactions with chat history to save and load messages on prompt
  • Respects abstraction's contract on add_message, this method should return None instead of ChatMessages instance.

fixed: #34
related: #21
@walison17 walison17 force-pushed the refactor-chat-memory-usage branch from 1a44867 to 719586b Compare November 22, 2023 16:05
avelino
avelino approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@avelino avelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@avelino avelino merged commit 4bc90d7 into talkdai:main Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@walison17 @avelino