_[WIP] Update load_csv to use Langchain CSVLoader #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmesel
requested changes
Jun 3, 2024
Member
vmesel
left a comment
vmesel
left a comment
There was a problem hiding this comment.
Just some minor changes, looks good to me on code, but need to test locally before we merge it
|
|
||
|
|
||
| def get_document_pk(doc: Document) -> str: | ||
| return ( |
Member
There was a problem hiding this comment.
My only concern here is that a string with special characters could break this logic on some level on the database side, I would just do a hash on top of this concatenation that would prevent anything of this to happen.
Collaborator
Author
There was a problem hiding this comment.
oh yes, I forgot to aplpy hash again, at some point I've missed it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #199