Skip to content

Better plugins installation #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2024
Merged

Better plugins installation #142

merged 2 commits into from
Feb 28, 2024

Conversation

@walison17
Copy link
Collaborator

@walison17 walison17 commented Feb 28, 2024

This way is a little faster and gives pip freedom to install transient dependencies in a compatible combination.
walison17
walison17 commented Feb 28, 2024
View reviewed changes
Dockerfile
COPY poetry.lock pyproject.toml /app/

RUN pip install poetry && \
RUN pip install -U pip poetry && \
Copy link
Collaborator Author

@walison17 walison17 Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we use pip to install plugins at runtime, it's good for it to be up-to-date
avelino
avelino approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@avelino avelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@avelino avelino merged commit dee0fc4 into talkdai:main Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@walison17 @avelino