Make session_id optional #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey @schumannc thanks for your PR, just to clarify: the intention here is to have a chat endpoint that does not have a session id, thus not creating memory instances and everything else, right? Talking to @walison17, we could maintain this endpoint, but we should rename this endpoint to |
Member
|
Also @schumannc could you share more of the use case you think makes this change necessary? |
Collaborator
Author
|
Another way would be implement the router using plugins, but I would keep the other changes to bypass the memory chat. |
walison17
suggested changes
Feb 23, 2024
src/main.py
Outdated
|
|
||
|
|
||
| @app.post("/chat") | ||
| async def post_message(message: Chat): |
Collaborator
There was a problem hiding this comment.
We already have a route with the same name
src/tests/test_views.py
Outdated
| self.assertIn("message", response.json()) | ||
|
|
||
| def test_post_message_no_session_id(self): | ||
| response = client.post(f"/chat", json={"message": "Hello"}) |
Collaborator
There was a problem hiding this comment.
Suggested change
| response = client.post(f"/chat", json={"message": "Hello"}) | |
| response = client.post("/chat", json={"message": "Hello"}) |
vmesel
requested changes
Feb 23, 2024
src/tests/test_views.py
Outdated
| self.assertIn("message", response.json()) | ||
|
|
||
| def test_post_message_no_session_id(self): | ||
| response = client.post(f"/chat", json={"message": "Hello"}) |
src/main.py
Outdated
|
|
||
|
|
||
| @app.post("/chat") | ||
| async def post_message(message: Chat): |
vmesel
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Endpoint for Chat Responses without Session ID:
Adding an endpoint to handle chats without a session ID. This could be especially useful for stateless interactions where context retention isn't necessary.
#118