Skip to content

Proposal: Allow overwriting static utilities that have a namespace #18056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 11, 2025
+972 −163
Merged

Proposal: Allow overwriting static utilities that have a namespace #18056

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a4714eb
Proposal: Allow overwriting static utilities that have a namespace
philipp-spiess May 16, 2025
2f04408
utilities: convert conflicting statics to functional staticValues; su…
philipp-spiess Sep 10, 2025
a8409d5
Update packages/tailwindcss/src/utilities.ts
philipp-spiess Sep 10, 2025
3037a11
utilities: auto-suggest staticValues in functionalUtility; keep sugge…
philipp-spiess Sep 10, 2025
9e274d6
Move suggestion into utility helper
philipp-spiess Sep 10, 2025
ad45c77
Run formatter
philipp-spiess Sep 10, 2025
69b94cd
Cleanup & changelog entry
philipp-spiess Sep 11, 2025
88b4541
Cleanups
philipp-spiess Sep 11, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move suggestion into utility helper
  • Loading branch information
@philipp-spiess
philipp-spiess committed Sep 11, 2025
commit 9e274d6d14035c44d4b0dbf688b9d46ed55f138f
175 changes: 22 additions & 153 deletions packages/tailwindcss/src/utilities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,8 +708,7 @@ export function createUtilities(theme: Theme) {
auto: [decl('grid-column', 'auto')],
},
})
// Ensure discoverability for `col-auto` after converting to fallback
suggest('col', () => [{ values: ['auto'], valueThemeKeys: ['--grid-column'] }])

functionalUtility('col-span', {
handleBareValue: ({ value }) => {
if (!isPositiveInteger(value)) return null
Expand Down Expand Up @@ -755,13 +754,12 @@ export function createUtilities(theme: Theme) {

suggest('col-span', () => [
{
values: ['full', ...Array.from({ length: 12 }, (_, i) => `${i + 1}`)],
values: Array.from({ length: 12 }, (_, i) => `${i + 1}`),
valueThemeKeys: [],
},
])

suggest('col-start', () => [
{ values: ['auto'], valueThemeKeys: ['--grid-column-start'] },
{
supportsNegative: true,
values: Array.from({ length: 13 }, (_, i) => `${i + 1}`),
Expand All @@ -770,7 +768,6 @@ export function createUtilities(theme: Theme) {
])

suggest('col-end', () => [
{ values: ['auto'], valueThemeKeys: ['--grid-column-end'] },
{
supportsNegative: true,
values: Array.from({ length: 13 }, (_, i) => `${i + 1}`),
Expand All @@ -793,8 +790,7 @@ export function createUtilities(theme: Theme) {
auto: [decl('grid-row', 'auto')],
},
})
// Ensure discoverability for `row-auto` after converting to fallback
suggest('row', () => [{ values: ['auto'], valueThemeKeys: ['--grid-row'] }])

functionalUtility('row-span', {
themeKeys: [],
handleBareValue: ({ value }) => {
Expand Down Expand Up @@ -841,13 +837,12 @@ export function createUtilities(theme: Theme) {

suggest('row-span', () => [
{
values: ['full', ...Array.from({ length: 12 }, (_, i) => `${i + 1}`)],
values: Array.from({ length: 12 }, (_, i) => `${i + 1}`),
valueThemeKeys: [],
},
])

suggest('row-start', () => [
{ values: ['auto'], valueThemeKeys: ['--grid-row-start'] },
{
supportsNegative: true,
values: Array.from({ length: 13 }, (_, i) => `${i + 1}`),
Expand All @@ -856,7 +851,6 @@ export function createUtilities(theme: Theme) {
])

suggest('row-end', () => [
{ values: ['auto'], valueThemeKeys: ['--grid-row-end'] },
{
supportsNegative: true,
values: Array.from({ length: 13 }, (_, i) => `${i + 1}`),
Expand Down Expand Up @@ -936,7 +930,7 @@ export function createUtilities(theme: Theme) {

suggest('line-clamp', () => [
{
values: ['none', '1', '2', '3', '4', '5', '6'],
values: ['1', '2', '3', '4', '5', '6'],
valueThemeKeys: ['--line-clamp'],
},
])
Expand Down Expand Up @@ -991,13 +985,7 @@ export function createUtilities(theme: Theme) {
},
})

// Suggest only the keyword aspect values (no fraction burst)
suggest('aspect', () => [
{
values: ['auto', 'square'],
valueThemeKeys: ['--aspect'],
},
])


/**
* @css `size`
Expand Down Expand Up @@ -1245,23 +1233,7 @@ export function createUtilities(theme: Theme) {
},
})

// Suggest keyword origin values to match snapshot
suggest('origin', () => [
{
values: [
'center',
'top',
'top-right',
'right',
'bottom-right',
'bottom',
'bottom-left',
'left',
'top-left',
],
valueThemeKeys: ['--transform-origin'],
},
])


functionalUtility('perspective-origin', {
themeKeys: ['--perspective-origin'],
Expand All @@ -1279,23 +1251,7 @@ export function createUtilities(theme: Theme) {
},
})

// Suggest keyword perspective-origin values to match snapshot
suggest('perspective-origin', () => [
{
values: [
'center',
'top',
'top-right',
'right',
'bottom-right',
'bottom',
'bottom-left',
'left',
'top-left',
],
valueThemeKeys: ['--perspective-origin'],
},
])


/**
* @css `perspective`
Expand All @@ -1308,13 +1264,7 @@ export function createUtilities(theme: Theme) {
},
})

// Suggest `perspective-none` to match snapshot
suggest('perspective', () => [
{
values: ['none'],
valueThemeKeys: ['--perspective'],
},
])


let translateProperties = () =>
atRoot([
Expand Down Expand Up @@ -1875,12 +1825,7 @@ export function createUtilities(theme: Theme) {
},
})

suggest('list', () => [
{
values: ['none', 'disc', 'decimal'],
valueThemeKeys: ['--list-style-type'],
},
])


// list-image-*

Expand All @@ -1892,12 +1837,7 @@ export function createUtilities(theme: Theme) {
},
})

suggest('list-image', () => [
{
values: ['none'],
valueThemeKeys: ['--list-style-image'],
},
])


staticUtility('appearance-none', [['appearance', 'none']])
staticUtility('appearance-auto', [['appearance', 'auto']])
Expand All @@ -1923,7 +1863,7 @@ export function createUtilities(theme: Theme) {

suggest('columns', () => [
{
values: ['auto', ...Array.from({ length: 12 }, (_, i) => `${i + 1}`)],
values: Array.from({ length: 12 }, (_, i) => `${i + 1}`),
valueThemeKeys: ['--columns', '--container'],
},
])
Expand Down Expand Up @@ -1957,12 +1897,7 @@ export function createUtilities(theme: Theme) {
},
})

suggest('auto-cols', () => [
{
values: ['auto', 'min', 'max', 'fr'],
valueThemeKeys: ['--grid-auto-columns'],
},
])


functionalUtility('auto-rows', {
themeKeys: ['--grid-auto-rows'],
Expand All @@ -1975,12 +1910,7 @@ export function createUtilities(theme: Theme) {
},
})

suggest('auto-rows', () => [
{
values: ['auto', 'min', 'max', 'fr'],
valueThemeKeys: ['--grid-auto-rows'],
},
])


functionalUtility('grid-cols', {
themeKeys: ['--grid-template-columns'],
Expand Down Expand Up @@ -2010,14 +1940,14 @@ export function createUtilities(theme: Theme) {

suggest('grid-cols', () => [
{
values: ['none', 'subgrid', ...Array.from({ length: 12 }, (_, i) => `${i + 1}`)],
values: Array.from({ length: 12 }, (_, i) => `${i + 1}`),
valueThemeKeys: ['--grid-template-columns'],
},
])

suggest('grid-rows', () => [
{
values: ['none', 'subgrid', ...Array.from({ length: 12 }, (_, i) => `${i + 1}`)],
values: Array.from({ length: 12 }, (_, i) => `${i + 1}`),
valueThemeKeys: ['--grid-template-rows'],
},
])
Expand Down Expand Up @@ -2280,31 +2210,7 @@ export function createUtilities(theme: Theme) {
})
}

// Ensure IntelliSense continues to suggest `none` and `full` for all rounded-* roots
for (let root of [
'rounded',
'rounded-s',
'rounded-e',
'rounded-t',
'rounded-r',
'rounded-b',
'rounded-l',
'rounded-ss',
'rounded-se',
'rounded-ee',
'rounded-es',
'rounded-tl',
'rounded-tr',
'rounded-br',
'rounded-bl',
]) {
suggest(root, () => [
{
values: ['none', 'full'],
valueThemeKeys: ['--radius'],
},
])
}

}

staticUtility('border-solid', [
Expand Down Expand Up @@ -3812,22 +3718,7 @@ export function createUtilities(theme: Theme) {
})

// Keep keyword object-position values discoverable in IntelliSense
suggest('object', () => [
{
values: [
'top',
'top-left',
'top-right',
'bottom',
'bottom-left',
'bottom-right',
'left',
'right',
'center',
],
valueThemeKeys: ['--object-position'],
},
])


for (let [name, property] of [
['p', 'padding'],
Expand Down Expand Up @@ -4062,12 +3953,7 @@ export function createUtilities(theme: Theme) {
},
})

suggest('animate', () => [
{
values: ['none'],
valueThemeKeys: ['--animate'],
},
])


{
let cssFilterValue = [
Expand Down Expand Up @@ -4179,12 +4065,7 @@ export function createUtilities(theme: Theme) {
},
})

suggest('blur', () => [
{
values: ['none'],
valueThemeKeys: ['--blur'],
},
])


functionalUtility('backdrop-blur', {
themeKeys: ['--backdrop-blur', '--blur'],
Expand All @@ -4204,12 +4085,7 @@ export function createUtilities(theme: Theme) {
},
})

suggest('backdrop-blur', () => [
{
values: ['none'],
valueThemeKeys: ['--backdrop-blur', '--blur'],
},
])


functionalUtility('brightness', {
themeKeys: ['--brightness'],
Expand Down Expand Up @@ -4931,13 +4807,7 @@ export function createUtilities(theme: Theme) {
},
)

// Ensure `leading-none` remains suggested
suggest('leading', () => [
{
values: ['none'],
valueThemeKeys: ['--leading', '--spacing'],
},
])


functionalUtility('tracking', {
supportsNegative: true,
Expand Down Expand Up @@ -5190,7 +5060,6 @@ export function createUtilities(theme: Theme) {
})

suggest('underline-offset', () => [
{ values: ['auto'], valueThemeKeys: ['--text-underline-offset'] },
{
supportsNegative: true,
values: ['0', '1', '2', '4', '8'],
Expand Down