Skip to content

Conversation

@wongjn
Copy link
Collaborator

@wongjn wongjn commented Jan 25, 2025

none is not a valid value for min-width or min-height according to the CSS spec:

Value: auto | <length-percentage> | min-content | max-content | fit-content(<length-percentage>)

I believe we should be able to remove the min-w-none and min-h-none class candidates since they wouldn't have done anything anyway and thus should not affect backwards compatibility. Indeed, these did not exist in v3 either:

minHeight: ({ theme }) => ({
...theme('spacing'),
full: '100%',
screen: '100vh',
svh: '100svh',
lvh: '100lvh',
dvh: '100dvh',
min: 'min-content',
max: 'max-content',
fit: 'fit-content',
}),

minWidth: ({ theme }) => ({
...theme('spacing'),
full: '100%',
min: 'min-content',
max: 'max-content',
fit: 'fit-content',
}),


Credit to @i on Discord for spotting this1, fixes #15846

Footnotes

  1. https://discord.com/channels/486935104384532500/486935104384532502/1332680061144403968

`none` is not a valid value for `min-width/height`.
@wongjn wongjn requested a review from a team as a code owner January 25, 2025 12:54
wongjn added a commit to wongjn/tailwindcss.com that referenced this pull request Jan 25, 2025
@adamwathan adamwathan enabled auto-merge (squash) January 25, 2025 17:02
@adamwathan
Copy link
Member

Thanks!

adamwathan pushed a commit to tailwindlabs/tailwindcss.com that referenced this pull request Jan 25, 2025
@adamwathan adamwathan merged commit 7e20c3b into tailwindlabs:next Jan 25, 2025
5 checks passed
@wongjn wongjn deleted the min-w-h-none branch January 25, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants