Write to stdout when --output is omitted
#15656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is similar to `--input -`, where it reads the input from stdin. We will default to `-` so that it always prints to stdout when you omit the `-o` option.
When parsing `-o -`, it parses as `o: true` because mri thinks that `-` is the start of a new argument, _I think_. So to solve it, we pre process the options to convert `-` to a fallback value, then parse and then convert it back. I wish we could use a symbol, but mri will crash.
If you just run `npx @tailwindcss/cli`, then apart from `npx` and `@tailwindcss/cli`, no other arguments are passed. In this case, the help should show.
This is the equivalent of: ``` echo '...' | node ./my-command.js ```
- One test reads from stdin (added for completeness) - One test writes to stdout
philipp-spiess
approved these changes
Jan 17, 2025
Co-authored-by: Philipp Spiess <hello@philippspiess.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the
@tailwindcss/cli, where omitting the--outputflag should output tostdoutbut it didn't. This PR fixes that by writing tostdoutif no--outputis passed.That said, if nothing is passed, then the
--helpwill show.In summary:
stdin, use:--input -or-i -stdout, use:--output -or-o -or omit entirelyFixes: #15648
Test plan
Added integration tests to ensure that reading / writing to stdin / stdout works as expected.
Ran the updated CLI in my terminal to show that the
--helpshows by default, but if you use any arguments (like an--input) that the result is printed tostdoutas expected.Note the
twcommand is just a shorthand for runningbun --bun ~/github.com/tailwindlabs/tailwindcss/packages/@tailwindcss-cli/src/index.ts.