Improve stylesheet "root" detection #1401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
commented
Jun 4, 2025
| config: 'packages/web/app.css', | ||
| selectors: [ | ||
| '{URL}/packages/shared/**', | ||
| '{URL}/packages/shared/ui.css', |
Contributor
Author
There was a problem hiding this comment.
I think these showing up indicates a problem with this approach. These show up because this is an imported file. this is generally fine
However, in this case it might be unexpected. Especially if packages/shared has its own Tailwind CSS config. It'll prefer packages/admin over packages/shared and that feels like a bug. 🤔
Contributor
Author
There was a problem hiding this comment.
I figured out a temporary solution that doesn't introduce potential issues like this. But it's kinda awful.
Will ship with it but it could use some improvement later.
thecrypticace
force-pushed
the
feat/improve-stylesheet-detection
branch
from
dbccdfb to
73330db
Compare
RobinMalfait
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1388
There's two problems here:
@importa potential root. This includes compiled stylesheets that have URL imports to things like google fonts