You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
splitsh.json has no entry for the bridge, so the package would never be split or published. Nothing guards that in CI, since package-tests skips component_bridge. The precedent is 0f5b9b6039d, which retrofitted Prelude.
The SQLite DSN reads three slashes as a relative path. amp-sqlite:///tmp/messages.db resolves to tmp/messages.db, and an absolute path needs amp-sqlite:////tmp/messages.db. Everywhere else three slashes means absolute, including sqlite:/// in the PDO cache and lock stores. testSupports and the Messenger TransportFactoryTest fixture both use the three-slash form, so the tests currently lock the behaviour in.
Smaller: createTransport() catches \Throwable and rethrows a bare "DSN is invalid" with no previous exception, so a bad sslmode or a typo in an option loses its cause. And the two [CI] commits reworking static-analysis.yml look unrelated to the bridge. They are also why PHPStan and Psalm are red here: the refresh step wipes composer.lock and reinstalls from the PR's own composer.json, so the base and the PR are no longer analysed against the same tree. Neither job reports anything in an AmpSql file.
splitsh.json has no entry for the bridge, so the package would never be split or published. Nothing guards that in CI, since package-tests skips component_bridge. The precedent is 0f5b9b6039d, which retrofitted Prelude.
The SQLite DSN reads three slashes as a relative path. amp-sqlite:///tmp/messages.db resolves to tmp/messages.db, and an absolute path needs amp-sqlite:////tmp/messages.db. Everywhere else three slashes means absolute, including sqlite:/// in the PDO cache and lock stores. testSupports and the Messenger TransportFactoryTest fixture both use the three-slash form, so the tests currently lock the behaviour in.
Smaller: createTransport() catches \Throwable and rethrows a bare "DSN is invalid" with no previous exception, so a bad sslmode or a typo in an option loses its cause. And the two [CI] commits reworking static-analysis.yml look unrelated to the bridge. They are also why PHPStan and Psalm are red here: the refresh step wipes composer.lock and reinstalls from the PR's own composer.json, so the base and the PR are no longer analysed against the same tree. Neither job reports anything in an AmpSql file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs: symfony/symfony-docs#22457
Adds a Symfony Messenger transport backed by asynchronous AMP SQL that allows to use Messenger without blocking an Amp event loop.