Emit line numbers in grep/sgrep output#3
Merged
Merged
Conversation
Resolve each matched chunk back to its source file (or transcription sidecar) and print the matching line range, e.g. `/notes.md:12-15:chunk text`. Falls back to whitespace-normalised matching when the verbatim search misses, keeping the old `file:content` format when no local file is available. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![vorflux[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/2483280?s=60&v=4){kind=small}
- Walker now skips through whole whitespace runs and lands on the next non-whitespace char that maps to the normalized position. Previous version stopped 1-2 chars short on chunks crossing blank lines or with leading whitespace. - Verbatim end-line uses the last char's start byte (avoids slicing mid-multibyte UTF-8 char and panicking on chunks ending in non-ASCII). - Per-loop file cache so each source file is read once across all hits. - Extracted line_range_in_file/read_local_or_sidecar as pure helpers with unit tests covering the walker's edge cases.
Prasanna721
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/notes.md:12-15:chunk textfile:contentformat when no local mount is availableTest plan
sgrepagainst a mounted container and verify line numbers appear🤖 Generated with Claude Code