Skip to content

Always remove the layer from layers array, even if session is null #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Always remove the layer from layers array, even if session is null #9

wants to merge 1 commit into from

Conversation

@vincentfretin
Copy link

@vincentfretin vincentfretin commented Dec 31, 2022

This closes aframevr/aframe#5197
You can merge and squash it with the commit 84b2da1 if you rebase -i next time you update threejs
@vincentfretin vincentfretin mentioned this pull request Dec 31, 2022
Closed
@dmarcos
Copy link
Member

dmarcos commented Jan 3, 2023

Thanks so much. I leave this open. Working on r147 branch will be confusing and high chance for me to mess things up. I'll create a new branch and cherry pick this commit for a new super-three release.
@vincentfretin
Copy link
Author

vincentfretin commented Jan 5, 2023

I see you cherry-picked the commit in https://github.com/supermedium/three.js/commits/super-147-1
@vincentfretin vincentfretin deleted the patch-1 branch January 5, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@vincentfretin @dmarcos