Skip to content

sun-sky to 1.4.1 #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 8, 2023
Merged

sun-sky to 1.4.1 #319

merged 5 commits into from
Mar 8, 2023

Conversation

@diarmidmackenzie
Copy link
Contributor

@diarmidmackenzie diarmidmackenzie commented Feb 18, 2023

Another component & examples brought up-to-date.

sun-sky was broken at 0.8.0 due to this issue:
aframevr/aframe#3370

Other issues found:

  • had to make some tweaks to get webpack builds working including GLSL files
  • there was no npm task to generate build.js. Aiming for simplicity, I just updated the examples to use the version already being built under /dist
@dmarcos dmarcos merged commit 0e515fc into supermedium:master Mar 8, 2023
@vincentfretin vincentfretin mentioned this pull request Jun 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@diarmidmackenzie @dmarcos