Skip to content

Commit 539cfd9

Browse files
committed
assert: minor refactor of compareTwoValues tests
Refactor compareTwoValues tests to free the 'compareResult' symbol name (for incoming use of this name in next commit).
1 parent d75ed1d commit 539cfd9

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

‎assert/assertion_compare_test.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -392,8 +392,8 @@ func Test_compareTwoValuesDifferentValuesTypes(t *testing.T) {
392392
{v1: float64(12), v2: "123"},
393393
{v1: "float(12)", v2: float64(1)},
394394
} {
395-
compareResult := compareTwoValues(mockT, currCase.v1, currCase.v2, []CompareType{compareLess, compareEqual, compareGreater}, "testFailMessage")
396-
False(t, compareResult)
395+
result := compareTwoValues(mockT, currCase.v1, currCase.v2, []CompareType{compareLess, compareEqual, compareGreater}, "testFailMessage")
396+
False(t, result)
397397
}
398398
}
399399

@@ -411,8 +411,8 @@ func Test_compareTwoValuesNotComparableValues(t *testing.T) {
411411
{v1: map[string]int{}, v2: map[string]int{}},
412412
{v1: make([]int, 5), v2: make([]int, 5)},
413413
} {
414-
compareResult := compareTwoValues(mockT, currCase.v1, currCase.v2, []CompareType{compareLess, compareEqual, compareGreater}, "testFailMessage")
415-
False(t, compareResult)
414+
result := compareTwoValues(mockT, currCase.v1, currCase.v2, []CompareType{compareLess, compareEqual, compareGreater}, "testFailMessage")
415+
False(t, result)
416416
}
417417
}
418418

@@ -431,8 +431,8 @@ func Test_compareTwoValuesCorrectCompareResult(t *testing.T) {
431431
{v1: 2, v2: 1, allowedResults: []CompareType{compareEqual, compareGreater}},
432432
{v1: 2, v2: 1, allowedResults: []CompareType{compareGreater}},
433433
} {
434-
compareResult := compareTwoValues(mockT, currCase.v1, currCase.v2, currCase.allowedResults, "testFailMessage")
435-
True(t, compareResult)
434+
result := compareTwoValues(mockT, currCase.v1, currCase.v2, currCase.allowedResults, "testFailMessage")
435+
True(t, result)
436436
}
437437
}
438438

@@ -447,8 +447,8 @@ func Test_containsValue(t *testing.T) {
447447
{values: []CompareType{compareGreater, compareLess}, value: compareLess, result: true},
448448
{values: []CompareType{compareGreater, compareLess}, value: compareEqual, result: false},
449449
} {
450-
compareResult := containsValue(currCase.values, currCase.value)
451-
Equal(t, currCase.result, compareResult)
450+
result := containsValue(currCase.values, currCase.value)
451+
Equal(t, currCase.result, result)
452452
}
453453
}
454454

0 commit comments

Comments
 (0)