Skip to content

Commit d75ed1d

Browse files
committed
assert: refactor Test_compareTwoValuesCorrectCompareResult
Refactor Test_compareTwoValuesCorrectCompareResult table test to be more explicit: "compareTypes" renamed to "allowedResults".
1 parent bb548d0 commit d75ed1d

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

‎assert/assertion_compare_test.go

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -420,18 +420,18 @@ func Test_compareTwoValuesCorrectCompareResult(t *testing.T) {
420420
mockT := new(testing.T)
421421

422422
for _, currCase := range []struct {
423-
v1 interface{}
424-
v2 interface{}
425-
compareTypes []CompareType
423+
v1 interface{}
424+
v2 interface{}
425+
allowedResults []CompareType
426426
}{
427-
{v1: 1, v2: 2, compareTypes: []CompareType{compareLess}},
428-
{v1: 1, v2: 2, compareTypes: []CompareType{compareLess, compareEqual}},
429-
{v1: 2, v2: 2, compareTypes: []CompareType{compareGreater, compareEqual}},
430-
{v1: 2, v2: 2, compareTypes: []CompareType{compareEqual}},
431-
{v1: 2, v2: 1, compareTypes: []CompareType{compareEqual, compareGreater}},
432-
{v1: 2, v2: 1, compareTypes: []CompareType{compareGreater}},
427+
{v1: 1, v2: 2, allowedResults: []CompareType{compareLess}},
428+
{v1: 1, v2: 2, allowedResults: []CompareType{compareLess, compareEqual}},
429+
{v1: 2, v2: 2, allowedResults: []CompareType{compareGreater, compareEqual}},
430+
{v1: 2, v2: 2, allowedResults: []CompareType{compareEqual}},
431+
{v1: 2, v2: 1, allowedResults: []CompareType{compareEqual, compareGreater}},
432+
{v1: 2, v2: 1, allowedResults: []CompareType{compareGreater}},
433433
} {
434-
compareResult := compareTwoValues(mockT, currCase.v1, currCase.v2, currCase.compareTypes, "testFailMessage")
434+
compareResult := compareTwoValues(mockT, currCase.v1, currCase.v2, currCase.allowedResults, "testFailMessage")
435435
True(t, compareResult)
436436
}
437437
}

0 commit comments

Comments
 (0)