This repository was archived by the owner on Dec 12, 2018. It is now read-only.
Adds optional support for new Account group association #1339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogeared
reviewed
Jun 13, 2017
| oktaAppConfigMap.put("userApiQueryTemplate", apiSecretQueryTemplate); | ||
| oktaAppConfigMap.put("applicationId", oktaApplicationId); | ||
| oktaAppConfigMap.put("passwordPolicyName", oktaPasswordPolicyName); | ||
| oktaAppConfigMap.put("oktaApplicationGroupId", oktaApplicationGroupId); |
Member
There was a problem hiding this comment.
Shouldn't all these use: OktaApplication., like OktaApplication.APPLICATION_GROUP_ID
Contributor
Author
There was a problem hiding this comment.
Nope, there is no dependency on impl, just a runtime dep
dogeared
reviewed
Jun 13, 2017
| String groupId = getStringProperty(OktaApplication.APPLICATION_GROUP_ID); | ||
| if (Strings.hasText(groupId)) { | ||
| associateUserWithGroup(account, groupId); | ||
| } |
Member
There was a problem hiding this comment.
nit - move else to previous line
Contributor
Author
There was a problem hiding this comment.
them is fighting words
Member
|
Minor nits. Feel free to update or not |
dogeared
approved these changes
Jun 13, 2017
bdemers
force-pushed
the
new-user-groupId
branch
from
adacebe to
1189d30
Compare
If the property 'okta.application.groupId' is set, newly created accounts will be added to that group. Otherwise the new account will be associated directly with the application.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the property 'okta.application.groupId' is set, newly created accounts will be added to that group.
Otherwise the new account will be associated directly with the application.