Include column types for composite type #3906
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
dosubot
bot
added
size:XL
|
Intentionally left endtoend test failing, until I verify that generated code does work as intended |
|
Tested this, breaks if a column is an array of composite type. Otherwise works fine, except that |
|
any update? will it get merged it? |
|
Doesn't look like anyone had a chance to review this PR, and I haven't reached out to anyone to speed this up. I'm surprised that it still doesn't have any conflicts, so I don't mind making small adjustments to get this merged if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this addition, it should be possible to implement codegen on pgx/v5 side to resolve #2760
. Not sure for other drivers.
I intend to implement codegen as part of this PR as well, just want to get visibility as soon as possible.