Skip to content

Allow for extra parameters to the queryType #2375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow for extra parameters to the queryType #2375

wants to merge 1 commit into from

Conversation

@Jille
Copy link
Contributor

@Jille Jille commented Jun 28, 2023

Like -- name: InsertMulti :exec multiple and -- name: Select :many key=group_id

This is the base for some future PRs I'll send.

issue #2353
@Jille Jille mentioned this pull request Jun 28, 2023
Open
@Jille Jille force-pushed the cmdparams branch 2 times, most recently from 3a2aad4 to b388336 Compare June 28, 2023 08:20
@Jille
Allow for extra parameters to the queryType
531e214 
Like `-- name: InsertMulti :exec multiple` and `-- name: Select :many key=group_id`

issue sqlc-dev#2353
@andrewmbenton
Copy link
Collaborator

andrewmbenton commented Jul 13, 2023 •
edited
Loading

Thoughts on an alternative proposal for additional query metadata here? #2454. The parsing is a little bit cleaner if we leave the existing single-line critical metadata alone.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@Jille @andrewmbenton