Skip to content

Conversation

@gebezs
Copy link

@gebezs gebezs commented Mar 28, 2022

  • dto's class javadoc:

    • added as description for the schema
  • controller's class javadoc:

    • added as description of the tag
  • controller's method javadoc:

    • first line as summary
    • everything as description
  • filters the generic responses by the declared exceptions:

    • only if override-with-generic-response-if-declared is true
  • @throws in method javadoc:

    • overrides the @return of the ExceptionHandler's method
    • only if override-with-generic-response-if-declared is true
  • Formatting

  • Test update for existing tests

    • ~150 tests
    • Run them one by one and compare the result to make sure nothing else changed
@gebezs gebezs mentioned this pull request Mar 28, 2022
gebezs added 2 commits April 11, 2022 14:29
dto's class javadoc:
  added as description for the schema
controller's class javadoc:
  added as description of the tag
controller's method javadoc:
  first line as summary
  everything as description
filters the generic responses by the declared exceptions:
  only if override-with-generic-response-if-declared is true
@throws in method javadoc:
  overrides the @return of the ExceptionHandler's method
  only if override-with-generic-response-if-declared is true
Summary is only filled using javadoc if there is no description from annotation.
Failing test update (missing summary or schema description and ordering).
@gebezs gebezs force-pushed the javadoc-enhancement branch from afe6f16 to 338574d Compare April 11, 2022 17:36
@gebezs gebezs marked this pull request as ready for review April 11, 2022 19:25
@bnasslahsen
Copy link
Collaborator

@gebezs,

Thank you for your contribution!

@bnasslahsen bnasslahsen merged commit 728d2c3 into springdoc:master Apr 20, 2022
mpleine pushed a commit to mpleine/springdoc-openapi that referenced this pull request May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants