Skip to content

Fix RestClient to use defaultRequest on RestClient.Builder #32034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
injae-kim wants to merge 1 commit into from
Closed

Fix RestClient to use defaultRequest on RestClient.Builder #32034

injae-kim wants to merge 1 commit into from

Conversation

@injae-kim
Copy link
Contributor

@injae-kim injae-kim commented Jan 15, 2024

Closes gh-32028

Motivation

Modification

  • Fix RestClient to use defaultRequest on RestClient.Builder

Result

  • Now RestClient uses defaultRequest that passed from RestClientBuilder.build() well
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 15, 2024
@injae-kim injae-kim mentioned this pull request Jan 15, 2024
Closed
injae-kim
injae-kim commented Jan 15, 2024
View reviewed changes
spring-web/src/main/java/org/springframework/web/client/DefaultRestClient.java
Comment on lines +461 to +463
if (defaultRequest != null) {
defaultRequest.accept(this);
}
Copy link
Contributor Author

@injae-kim injae-kim Jan 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spring-framework/spring-webflux/src/main/java/org/springframework/web/reactive/function/client/DefaultWebClient.java

Lines 481 to 484 in faba044

private ClientRequest.Builder initRequestBuilder() {
if (defaultRequest != null) {
defaultRequest.accept(this);
}

FYI) almost same usage of defaultRequest on WebClient~!
@poutsma
Copy link
Contributor

poutsma commented Jan 17, 2024

Superseded by 0ada78a.
@poutsma poutsma closed this Jan 17, 2024
@poutsma poutsma added status: declined A suggestion or change that we don't feel we should currently apply in: web Issues in web modules (web, webmvc, webflux, websocket) and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: web Issues in web modules (web, webmvc, webflux, websocket) status: declined A suggestion or change that we don't feel we should currently apply

3 participants

@injae-kim @poutsma @spring-projects-issues