Skip to content

get rid of nose #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MeggyCal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

get rid of nose #529

MeggyCal wants to merge 1 commit into from

Conversation

@MeggyCal
Copy link

@MeggyCal MeggyCal commented Jan 20, 2021

As nose is unmaintained for a while, let us replace it with unittest.
@MeggyCal MeggyCal force-pushed the master branch 3 times, most recently from 4870677 to 114da2a Compare January 20, 2021 15:51
@MeggyCal
Copy link
Author

MeggyCal commented Jan 20, 2021

... and tests don't work, because I don't know how to setup your environment :( would you help me with that, please?
@erikbern
Copy link
Collaborator

erikbern commented Jan 20, 2021

Thanks for the PR! I think it fails because of something with how python setup.py nosetests builds the library before it runs the test. You might have to add a separate step to build the module first. I can clone and take a look.
@nadzhou
Copy link

nadzhou commented Mar 25, 2025

Thanks for the PR! I think it fails because of something with how python setup.py nosetests builds the library before it runs the test. You might have to add a separate step to build the module first. I can clone and take a look.

Should be easy to do I'd think. A simple pip install -e . or adding the repo directory to $PATH.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@MeggyCal @erikbern @nadzhou