Skip to content

Fix 456 (unaligned memory for Hamming) #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
erikbern wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix 456 (unaligned memory for Hamming) #457

erikbern wants to merge 3 commits into from

Conversation

@erikbern
Copy link
Collaborator

@erikbern erikbern commented Feb 24, 2020

This might fix it, @jlmelville wdyt?
@jlmelville
Copy link

jlmelville commented Feb 25, 2020

Thanks for attempting this so quickly @erikbern. This passes the GCC-UBSAN check on Rhub, but it's hard to be certain of the fix because due to the stochastic nature of the original problem.
@erikbern
Copy link
Collaborator Author

erikbern commented Feb 25, 2020

cool. i'll try to address the failing travis build in the near future
@jayvdb
Copy link

jayvdb commented Feb 7, 2021

note this causes segfaults in hamming_index_test.py::HammingIndexTest::test_many_vectors
@erikbern
Copy link
Collaborator Author

erikbern commented Feb 8, 2021

i completely forgot about this PR, will revisit shortly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@erikbern @jlmelville @jayvdb