Skip to content

Conversation

@NewNoob2002
Copy link
Contributor

I see commands in Unicore_Reference_Commands_Manual_For_N4_High_Precision_Products_V2_CH_R1_6, only MODE is two bytes in checksum, others are almost 8 types.
Update checksum bytes for Unicore hash parsing: 8 bytes default, 2 for MODE messages

@nseidle
Copy link
Member

nseidle commented Apr 8, 2025

Thank you for this! Can you give me an example where this library was failing and this PR fixes it? I'd like to test it.

@NewNoob2002
Copy link
Contributor Author

NewNoob2002 commented Apr 9, 2025

Hi, I tried to get BASEINFOA yesterday, but couldn't get anything, so I opened the debug port and saw that the parser statement returned was garbled, but the # header was indeed found and the command name was displayed, but the subsequent errors were wrong, so the complete ASCII statement could not be returned.
The following is what should appear
#BASEINFOA,98,GPS,UNKNOWN,0,0,0,0,18,0;00000001,0.000,0.000,0.000,"",0*c5da0858
but i debug print is just like garbled, i guess it's hex, so i found the Parse_Unicore_Hash.cpp files, see the checksum is not match in command doc, It is only effective under the MODE command, after i modify, i get the true parser sentence
#BASEINFOA,98,GPS��h�>��>�o@�E@�|>p>����5�?Bɰ���=������?�"
You can try get any other ASCII message except MODE

@nseidle
Copy link
Member

nseidle commented Apr 16, 2025

Excellent thanks! Merging.

@nseidle nseidle merged commit edb18fc into sparkfun:main Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants