Skip to content

fix: move @types/component-emitter to dependencies - #99

Merged
darrachequesne merged 1 commit into
socketio:masterfrom
P4sca1:master
Nov 25, 2020
Merged

fix: move @types/component-emitter to dependencies#99
darrachequesne merged 1 commit into
socketio:masterfrom
P4sca1:master

Conversation

@P4sca1

@P4sca1 P4sca1 commented Nov 19, 2020

Copy link
Copy Markdown
Contributor

Otherwise consumers of socket.io-parser (and socket.io) need to have it listed in their devDependencies.

While doing this I noticed that npm audit reported a lot of issues. It might be worth to upgrade dependencies.

Signed-off-by: Pascal Sthamer sthamer.pascal@gmail.com
@P4sca1
fix: move @types/component-emitter to dependencies
7bcf7b6 
Otherwise consumers of socket.io-parser (and socket.io) need to have it listed in their devDependencies.

Signed-off-by: Pascal Sthamer <sthamer.pascal@gmail.com>
@P4sca1 P4sca1 mentioned this pull request Nov 25, 2020
Closed
@darrachequesne
darrachequesne merged commit 4efa005 into socketio:master Nov 25, 2020
@darrachequesne

darrachequesne commented Nov 25, 2020

Copy link
Copy Markdown
Member

Thanks!

Regarding the audit, most of the issues comes from zuul, which is no longer maintained. We'll likely switch to karma in the future.
@darrachequesne

darrachequesne commented Nov 25, 2020

Copy link
Copy Markdown
Member

Included in 4.0.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@P4sca1 @darrachequesne