Fix/ctf run tests quarantine #1290
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
erikburt
force-pushed
the
fix/ctf-run-tests-quarantine
branch
from
a015bd2 to
f605147
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds a
quarantineinput toctf-run-testsMotivation
We are still seeing failures from E2E tests even when a quarantined test is failing. For example: https://github.com/smartcontractkit/chainlink/actions/runs/18511760513/job/52754448001?pr=19892#step:17:235
Seems like this is because the
continue-on-errorisn't working on a composite action step? So we throw it into the run test as well.Testing
smartcontractkit/chainlink#19893 / https://github.com/smartcontractkit/chainlink/actions/runs/18512425956?pr=19893