Skip to content

[WIP] make @compile_fun correctly recurse through imported names, to try to fix #52 #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
smarie wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[WIP] make @compile_fun correctly recurse through imported names, to try to fix #52 #53

smarie wants to merge 2 commits into from

Conversation

@smarie
Copy link
Owner

@smarie smarie commented Mar 23, 2020

This is work in progress: basically co_names should be used (done)

But it seems that there are issues with the way the eval dict (globals/locals) is propagated. Indeed when an external symbol is compiled, the eval dict should not be propagated. Instead its own eval dict should be used. This is available through target.__globals__ for functions, but not for other symbols (classes...).

Not sure all of this is done correctly today but I actually do not have time to dedicate to it as I am not sure about the potential benefits :)
Base automatically changed from master to main March 22, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@smarie