Skip to content

Replaced disqus with discourse #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2017
Merged

Conversation

travissarles
Copy link
Contributor

I could only partly test this locally because of CORS being disabled. However, it looks like it embeds properly.

@SethTisue
Copy link
Member

addresses #744

@heathermiller
Copy link
Member

Woohoo! 👍 Ok, merging optimistically – we can revert or add follow-up commits if anything looks amiss.

@heathermiller heathermiller merged commit b049d31 into scala:master Jun 6, 2017
@SethTisue
Copy link
Member

@travissarles this is still on the front page:

screen shot 2017-06-06 at 3 04 19 pm

on e.g. the tour pages themselves, the Disqus stuff has disappeared, but I don't see any new Discourse stuff yet

@travissarles
Copy link
Contributor Author

We're having CORS issues. I'm trying to figure it out. Let me know if you have any ideas.

Uncaught DOMException: Failed to read the 'contentDocument' property from 'HTMLIFrameElement': Blocked a frame with origin "http://docs.scala-lang.org" from accessing a cross-origin frame.
VM4658 comments?embed_url=http%3A%2F%2Fdocs.scala-lang.org%2Ftutorials%2Ftour%2F_posts%2F2017-02-13…:16 Failed to execute 'postMessage' on 'DOMWindow': The target origin provided ('https://users.scala-lang.org') does not match the recipient window's origin ('http://docs.scala-lang.org').
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants