Skip to content

SIP for adding co-monadic comprehensions #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2017
Merged

Conversation

shimib
Copy link
Contributor

@shimib shimib commented Feb 22, 2017

No description provided.

@jvican
Copy link
Member

jvican commented Mar 7, 2017

Hello @shimib!

Thank you for submitting a SIP and helping us improving Scala. After the discussions in Scala Contributors and the scala/scala implementation, the SIP Committee will review this proposal this month.

I think the proposal is great. I just have one suggestion: could you make it more obvious that this proposal enjoys of an existing implementation? The fact that you're already providing an implementation makes it easier to review, which I appreciate and I'm sure others will. Write a few sentences in the introduction and you're done.

I'm happy to merge this as soon as it's ready so that we can all see it in the official SIP website 😉.

@shimib
Copy link
Contributor Author

shimib commented Mar 8, 2017

@jvican done :)

@shimib
Copy link
Contributor Author

shimib commented Mar 23, 2017

@jvican is there something more needed from me for merging this SIP?

@jvican
Copy link
Member

jvican commented Mar 23, 2017

No 😄. Let's do it.

@jvican jvican merged commit 69b5cf5 into scala:master Mar 23, 2017
@shimib
Copy link
Contributor Author

shimib commented Mar 23, 2017 via email

@jvican
Copy link
Member

jvican commented Apr 6, 2017

Hello @shimib, I'm adding this to the upcoming SIP meeting happening this month! Thanks for your work 😄.

@shimib
Copy link
Contributor Author

shimib commented Apr 6, 2017

Thanks @jvican , I really appreciate it :)

Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an interesting effort, but I think it's premature. We should first see whether comonadic abstractions become popular before inventing syntax for them. Monadic abstractions with map/flatMap don't need for-expressions; they would be popular even if no such expressions existed.

Analogously I would like to see extensive use of comap and coflatmap in common Scala libraries before considering a syntax addition to better support them.

Scala's syntax is actually quite small, and I'd like to keep it that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants