Skip to content

Make Finding Implicits easier to read #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2017
Merged

Make Finding Implicits easier to read #664

merged 1 commit into from
Jan 31, 2017

Conversation

janekdb
Copy link
Member

@janekdb janekdb commented Jan 25, 2017 •
edited
Loading

  • Drop first person voice
  • Dial down humour setting to 20% by removing distracting Other Dimensions
  • Add link to issues
  • Update links to language specification
  • Remove comment about revision of StackOverflow answer because the reader
    won't have seen the previous slightly incorrect version
@janekdb janekdb force-pushed the topic/finding-implicits-fixes-2 branch 2 times, most recently from 752d874 to 5b42b27 Compare January 29, 2017 20:27
@janekdb
Make Finding Implicits easier to read
773c2fc 
 - Drop first person voice
 - Dial down humour setting to 20% by removing distracting Other Dimensions
 - Add link to issues
 - Update links to language specification
 - Remove comment about revision of StackOverflow answer because the reader
   won't have seen the previous slightly incorrect version
@janekdb janekdb force-pushed the topic/finding-implicits-fixes-2 branch from 5b42b27 to 773c2fc Compare January 29, 2017 20:31
@janekdb
Copy link
Member Author

janekdb commented Jan 29, 2017

Need help on the build,

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated
@heathermiller
Copy link
Member

Thanks for the ping, @janekdb. You just made me realize that I have the power to restart builds 🙂

Looks like the build just timed out. Trying again.
heathermiller
heathermiller approved these changes Jan 31, 2017
View reviewed changes
Copy link
Member

@heathermiller heathermiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @janekdb!
@SethTisue SethTisue merged commit 79f3ea6 into scala:master Jan 31, 2017
@SethTisue
Copy link
Member

thanks Janek!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@janekdb @heathermiller @SethTisue