Skip to content

Clarify the role of implicit conversion language feature imports #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2017
Merged

Clarify the role of implicit conversion language feature imports #662

merged 1 commit into from
Jan 26, 2017

Conversation

janekdb
Copy link
Member

@janekdb janekdb commented Jan 22, 2017

No description provided.

@janekdb
Copy link
Member Author

janekdb commented Jan 22, 2017

Review by @SethTisue
@SethTisue SethTisue self-assigned this Jan 23, 2017
janekdb
janekdb commented Jan 24, 2017
View reviewed changes
tutorials/tour/implicit-conversions.md
* Import `scala.language.implicitConversions` into the scope of the implicit conversion definition
* Invoke the compiler with `-language:implicitConversions`

No warning is emitted when the conversion is applied by the compiler.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is used by the compiler clearer?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me as is
@SethTisue
Copy link
Member

excellent, thank you Janek!
@SethTisue SethTisue merged commit f18a5e2 into scala:master Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@janekdb @SethTisue