Skip to content

Value class member need not be public in 2.11+ (in japanese value-classes.md) #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Value class member need not be public in 2.11+ (in japanese value-classes.md) #634

wants to merge 1 commit into from

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Nov 27, 2016

eed3si9n
eed3si9n requested changes Nov 27, 2016
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a translation, I think we should take the following two steps.

  1. Track all commits in the history (There are only 2 of them) - https://github.com/scala/scala.github.com/commits/master/overviews/core/_posts/2012-11-03-value-classes.md
  2. If you're introducing a change to the content (e.g. removing the word "public") the change should be made simultaneously to the English original document.
@SethTisue
Copy link
Member

@xuwei-k interested in getting this across the finish line...?
@SethTisue
Copy link
Member

closing for inactivity — can be reopened on request
@SethTisue SethTisue closed this Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@xuwei-k @SethTisue @eed3si9n