-
Notifications
You must be signed in to change notification settings - Fork 1k
WIP: Update "Futures and Promises" Japanese documentation #478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add Execution Context - Update some outdated lines - Replace deprecated future method with Future.apply
Thanks! @eed3si9n, would you care to do a quick pass to double check for errors? (It's short!) |
It would be easier to review tracking changes if the commit message included the original change commits like this - 43e4f91 |
@@ -99,7 +276,7 @@ Future オブジェクトを返すメソッドだということだ。 | |||
テキストファイルがあったとして、その中である特定のキーワードが最初に出てきた位置を知りたいとする。 | |||
この計算はファイルの内容をディスクから読み込むのにブロッキングする可能性があるため、他の計算と並行実行するのは理にかなっている。 | |||
|
|||
val firstOccurence: Future[Int] = future { | |||
val firstOccurence: Future[Int] = Future { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/firstOccurence/firstOccurrence/ tracking ce85413
Note: History of the original file 1b13478 / 6e0da87 tracking was skipped at「 これは getFriends メソッドで例示されている。」 Other untracked changes: This PR is mostly about 6c22f79, but the first part of the change that adds link to http://www.scala-lang.org/api/current/index.html#scala.concurrent.Future is missing. (Not sure if we need to hold Sera-san responsible for getting everything up to date) |
<!-- Both code snippets delegate the execution of `fatMatrix.inverse()` to an `ExecutionContext` and embody the result of the computation in `inverseFuture`. --> | ||
どちらのコードスニペットも `fatMatrix.inverse()` の実行を `ExecutionContext` に移譲し、その計算結果を `inverseFuture` として具体化している。 | ||
|
||
## Execution Context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
原文: Execution Context
訳案: 実行コンテキスト
後の方で、「実行コンテキスト(execution context)」という記述がありますが、それをやるならここで訳語を見出しに持ってきたほうがいいと思います。もしくは、ずっと Execution Context で通すか。
@heathermiller @eed3si9n Thank you for your quick response!
Got it, I'll do that. I'll fix all the untracked changes as well. |
Thanks! Sorry for pulling you into the rabbit hole :) |
Thank you @seratch! |
@SethTisue Sorry for my late reply. I couldn't work on this after that... When I will start working on this, I will do a rebase with the latest revision. I've marked the subject of this PR as WIP so far. |
@seratch want to get this over the finish line...? |
@SethTisue At the current moment, I'd like to spend my time for other things. I hope someone will take over the work. Anyway, let me close this so far. |
This pull request contains the following changes to fix some outdated parts of "Futures and Promises" Japanese documentation.