@compileTimeOnly for macro annotations #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| First of all, note the `@compileTimeOnly` annotation. It is not mandatory, but is recommended to avoid confusion. | ||
| Macro annotations look like normal annotations to the vanilla Scala compiler, so if you forget to enable the macro paradise | ||
| plugin in your build, your annotations will silently fail to expand. The `@compileTimeOnly` annotation makes sure that | ||
| no references to the underlying definition is present in the program code after typer, so it will prevent the aforementioned |
There was a problem hiding this comment.
Change "definition is present" to "definition are present".
There was a problem hiding this comment.
Or better still, to prefer the singular, change "sure that no references to the underlying definition is present" to "sure that no reference to the underlying definition is present" (delete the s from references).
There was a problem hiding this comment.
Done. Is the change otherwise LGTY?
There was a problem hiding this comment.
Thanks! I'll merge then.
xeno-by
added a commit
that referenced
this pull request
Feb 27, 2015
@compileTimeOnly for macro annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.