Skip to content

Enhance Comparison Section for Python Developers #2893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Enhance Comparison Section for Python Developers #2893

wants to merge 1 commit into from

Conversation

samadpls
Copy link

No description provided.

Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for opening this PR, however I must say that it was very tiring to review this.

As you did not provide any description of the changes I had to read every single line to try to understand what you did.

It seems like you have just nitpicked every single line for your personal writing style preference, while keeping the meaning identical. In my view we should try and respect the work that has come before from other contributors, particularly when the meaning can already be understood.

Please keep changes to only additions of meaningfully new content, deletion of outdated content, or fixes to spelling/grammar mistakes.

@samadpls
Copy link
Author

I apologize for my oversight in the recent pull request. I realize that I didn't provide a proper description of the changes, making the review process more challenging for you. My intention wasn't to nitpick or disregard previous contributions. I'm truly sorry for any frustration this may have caused.

You are absolutely right that respecting the work of other contributors and maintaining a balance between personal preferences and the existing meaning is crucial. I appreciate your feedback and I'm committed to making the necessary improvements.

@samadpls samadpls closed this Aug 30, 2023
@samadpls samadpls deleted the patch-1 branch August 30, 2023 10:36
@bishabosha
Copy link
Member

Hey, thank your understanding, I hope to see you contribute again soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants