add code tabs in TWO ca-given-imports.md #2824
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
requested changes
May 31, 2023
|
|
||
| #### Implement “equals” to make them really work | ||
|
|
||
| While these comparisons are now allowed, they will always be `false` because their `equals` methods don’t know how to make these comparisons. | ||
| Therefore, the solution is to override the `equals` methods for each class. | ||
| For instance, when you override the `equals` method for `AudioBook`: | ||
|
|
||
| {% tabs multiequ11 class=tabs-scala-version %} | ||
| {% tab 'Scala 2' %} |
|
Ping @scala/docs-zh. |
julienrf
requested changes
Jun 1, 2023
There was a problem hiding this comment.
Hey @benluo, thank you for the PR but since given imports and multiversal equality are features specific to Scala 3, we decided to label the whole page as “Scala 3 specific” instead of each code example (hence the absence of tabs on code snippets). You can see the guidelines here.
Could you please remove the tabs on the pages ca-given-imports and ca-multiversal-equality? Also in the future it would be easier to open separate PRs for changes in the documentation and changes in translations. Thank you!
Co-authored-by: Sébastien Doeraene <sjrdoeraene@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.