-
Notifications
You must be signed in to change notification settings - Fork 1k
Update the binary compatibility guarantees for Scala 3. #2804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is a great improvement!
I know the original document is only about binary compatibility, but I think it would be useful to also cover source compatibility. I think we could say that we can not guarantee backward source compatibility across compiler releases, but we have some tools (the open community build) to detect such incompatibilities and mitigate them, especially within an LTS series.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I only suggest describing the distinction between JVM's LinkageError
s and build-time linking errors from other platforms in more detail.
2eeb0f0
to
82cd92c
Compare
Updated to address the reviews. |
In addition, be a more assertive that we strongly *intend* compatibility of produced artifacts to be preserved, while still making it clear that we cannot *guarantee* it as it is not mechanically checkable.
82cd92c
to
ab786ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content looks good to me. I still think we should clarify the source compatibility guarantees, but that can be achieved in a separate PR.
In addition, be a more assertive that we strongly intend compatibility of produced artifacts to be preserved, while still making it clear that we cannot guarantee it as it is not mechanically checkable.